fix: don't return a non-nil interface containing nil pointer

2023-03-10 12:06:40 +08:00
parent dca98b7aa1
commit 9ae0bd9c2b
3 changed files with 8 additions and 8 deletions
--- a/component/dialer/dialer.go
+++ b/component/dialer/dialer.go
@ -170,7 +170,7 @@ func dualStackDialContext(ctx context.Context, dialFn dialFunc, network string,
 			select {
 			case results <- result:
 			case <-returned:
-				if result.Conn != nil {
+				if result.Conn != nil && result.error == nil {
 					_ = result.Conn.Close()
 				}
 			}
@ -218,7 +218,7 @@ func parallelDialContext(ctx context.Context, network string, ips []netip.Addr,
 			select {
 			case results <- result:
 			case <-returned:
-				if result.Conn != nil {
+				if result.Conn != nil && result.error == nil {
 					_ = result.Conn.Close()
 				}
 			}