From 52bdbf35dbc9a484bf2d4385a6665399a5de0a2c Mon Sep 17 00:00:00 2001 From: Stenzek Date: Tue, 23 Apr 2024 16:25:36 +1000 Subject: [PATCH] Qt: Fix rare crash during update download Thanks to Silent for debugging. --- src/duckstation-qt/autoupdaterdialog.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/duckstation-qt/autoupdaterdialog.cpp b/src/duckstation-qt/autoupdaterdialog.cpp index e1f288d5e..b74dbfded 100644 --- a/src/duckstation-qt/autoupdaterdialog.cpp +++ b/src/duckstation-qt/autoupdaterdialog.cpp @@ -440,6 +440,10 @@ void AutoUpdaterDialog::downloadUpdateClicked() }, &progress); + // Since we're going to block, don't allow the timer to poll, otherwise the progress callback can cause the timer to + // run, and recursively poll again. + m_http_poll_timer->stop(); + // Block until completion. while (m_http->HasAnyRequests()) {