Various warning fixes

src/common/string_util.cpp

@@ -167,27 +167,26 @@ std::size_t Strlcpy(char* dst, const std::string_view& src, std::size_t size)
 std::optional<std::vector<u8>> DecodeHex(const std::string_view& in)
 {
   std::vector<u8> data;
-  data.reserve(in.size()/2);
+  data.reserve(in.size() / 2);
 
-  for (int i = 0; i < in.size()/2; i++) {
-    auto byte = StringUtil::FromChars<u8>(in.substr(i*2, 2), 16);
-    if (byte) {
+  for (size_t i = 0; i < in.size() / 2; i++)
+  {
+    std::optional<u8> byte = StringUtil::FromChars<u8>(in.substr(i * 2, 2), 16);
+    if (byte.has_value())
       data.push_back(*byte);
-    }
-    else {
+    else
       return std::nullopt;
-    }
   }
 
-  return { data };
+  return {data};
 }
 
 std::string EncodeHex(const u8* data, int length)
 {
   std::stringstream ss;
-  for (int i = 0; i < length; i++) {
+  for (int i = 0; i < length; i++)
     ss << std::hex << std::setfill('0') << std::setw(2) << static_cast<int>(data[i]);
-  }
+  
   return ss.str();
 }
 

src/common/vulkan/swap_chain.cpp

@@ -133,8 +133,9 @@ static VkSurfaceKHR CreateDisplaySurface(VkInstance instance, VkPhysicalDevice p
     {
       Log_DevPrintf("  Mode %ux%u @ %u", mode.parameters.visibleRegion.width, mode.parameters.visibleRegion.height,
                     mode.parameters.refreshRate);
-      if (!matched_mode && (wi.surface_width == 0 && wi.surface_height == 0) ||
-          (mode.parameters.visibleRegion.width == wi.surface_width && mode.parameters.visibleRegion.height))
+      if (!matched_mode &&
+          ((wi.surface_width == 0 && wi.surface_height == 0) ||
+           (mode.parameters.visibleRegion.width == wi.surface_width && mode.parameters.visibleRegion.height)))
       {
         matched_mode = &mode;
       }

src/common/vulkan/util.cpp

@@ -9,7 +9,6 @@
 #include "../string_util.h"
 #include "context.h"
 #include "shader_compiler.h"
-Log_SetChannel(Vulkan::Util);
 
 namespace Vulkan {
 namespace Util {