Qt: Fix crash on shutdown settings save

This commit is contained in:
Stenzek 2024-04-05 14:27:37 +10:00
parent 3d84da0ddd
commit bdafbe0b28
No known key found for this signature in database

View File

@ -1820,14 +1820,18 @@ void QtHost::SaveSettings()
AssertMsg(!g_emu_thread->isOnThread(), "Saving should happen on the UI thread."); AssertMsg(!g_emu_thread->isOnThread(), "Saving should happen on the UI thread.");
{ {
Error error;
auto lock = Host::GetSettingsLock(); auto lock = Host::GetSettingsLock();
if (!s_base_settings_interface->Save()) if (!s_base_settings_interface->Save(&error))
Log_ErrorPrintf("Failed to save settings."); Log_ErrorFmt("Failed to save settings: {}", error.GetDescription());
} }
if (s_settings_save_timer)
{
s_settings_save_timer->deleteLater(); s_settings_save_timer->deleteLater();
s_settings_save_timer.release(); s_settings_save_timer.release();
} }
}
void QtHost::QueueSettingsSave() void QtHost::QueueSettingsSave()
{ {