Misc: Make struct member functions file-local

This commit is contained in:
Stenzek
2023-11-18 16:21:51 +10:00
parent bee1f986a9
commit cce7be4723
39 changed files with 680 additions and 595 deletions

View File

@ -33,6 +33,7 @@
Log_SetChannel(ByteStream);
namespace {
class FileByteStream : public ByteStream
{
public:
@ -174,10 +175,7 @@ public:
return true;
}
u64 GetPosition() const override
{
return _ftelli64(m_pFile);
}
u64 GetPosition() const override { return _ftelli64(m_pFile); }
u64 GetSize() const override
{
@ -232,10 +230,7 @@ public:
return true;
}
u64 GetPosition() const override
{
return static_cast<u64>(ftello(m_pFile));
}
u64 GetPosition() const override { return static_cast<u64>(ftello(m_pFile)); }
u64 GetSize() const override
{
@ -262,15 +257,9 @@ public:
return true;
}
virtual bool Commit() override
{
return true;
}
virtual bool Commit() override { return true; }
virtual bool Discard() override
{
return false;
}
virtual bool Discard() override { return false; }
protected:
FILE* m_pFile;
@ -364,10 +353,15 @@ private:
std::string m_originalFileName;
std::string m_temporaryFileName;
};
} // namespace
NullByteStream::NullByteStream() {}
NullByteStream::NullByteStream()
{
}
NullByteStream::~NullByteStream() {}
NullByteStream::~NullByteStream()
{
}
bool NullByteStream::ReadByte(u8* pDestByte)
{
@ -456,7 +450,9 @@ MemoryByteStream::MemoryByteStream(void* pMemory, u32 MemSize)
m_pMemory = (u8*)pMemory;
}
MemoryByteStream::~MemoryByteStream() {}
MemoryByteStream::~MemoryByteStream()
{
}
bool MemoryByteStream::ReadByte(u8* pDestByte)
{
@ -586,7 +582,9 @@ ReadOnlyMemoryByteStream::ReadOnlyMemoryByteStream(const void* pMemory, u32 MemS
m_pMemory = reinterpret_cast<const u8*>(pMemory);
}
ReadOnlyMemoryByteStream::~ReadOnlyMemoryByteStream() {}
ReadOnlyMemoryByteStream::~ReadOnlyMemoryByteStream()
{
}
bool ReadOnlyMemoryByteStream::ReadByte(u8* pDestByte)
{
@ -1346,6 +1344,7 @@ bool ByteStream::WriteBinaryToStream(ByteStream* stream, const void* data, size_
return stream->Write2(data, static_cast<u32>(data_length));
}
namespace {
class ZstdCompressStream final : public ByteStream
{
public:
@ -1489,12 +1488,14 @@ private:
u8 m_input_buffer[INPUT_BUFFER_SIZE];
u8 m_output_buffer[OUTPUT_BUFFER_SIZE];
};
} // namespace
std::unique_ptr<ByteStream> ByteStream::CreateZstdCompressStream(ByteStream* src_stream, int compression_level)
{
return std::make_unique<ZstdCompressStream>(src_stream, compression_level);
}
namespace {
class ZstdDecompressStream final : public ByteStream
{
public:
@ -1643,6 +1644,7 @@ private:
u8 m_input_buffer[INPUT_BUFFER_SIZE];
u8 m_output_buffer[OUTPUT_BUFFER_SIZE];
};
} // namespace
std::unique_ptr<ByteStream> ByteStream::CreateZstdDecompressStream(ByteStream* src_stream, u32 compressed_size)
{

View File

@ -14,6 +14,7 @@
#include "thirdparty/StackWalker.h"
#include <DbgHelp.h>
namespace {
class CrashHandlerStackWalker : public StackWalker
{
public:
@ -26,6 +27,7 @@ protected:
private:
HANDLE m_out_file;
};
} // namespace
CrashHandlerStackWalker::CrashHandlerStackWalker(HANDLE out_file)
: StackWalker(RetrieveVerbose, nullptr, GetCurrentProcessId(), GetCurrentProcess()), m_out_file(out_file)
@ -213,12 +215,14 @@ void CrashHandler::Uninstall()
#include <unistd.h>
namespace CrashHandler {
namespace {
struct BacktraceBuffer
{
char* buffer;
size_t used;
size_t size;
};
} // namespace
static const char* GetSignalName(int signal_no);
static void AllocateBuffer(BacktraceBuffer* buf);