diff --git a/router/handler/onvif/connection.go b/router/handler/onvif/connection.go index 979df28..55b4d39 100644 --- a/router/handler/onvif/connection.go +++ b/router/handler/onvif/connection.go @@ -29,9 +29,7 @@ func CreateConnection(c *gin.Context) { return } - conns[conn.Device.GetDeviceParams().Xaddr] = conn - - info, err := conn.GetDeviceInformation() + info, err := conn.GetDeviceInfo() if err != nil { c.JSON(http.StatusInternalServerError, gin.H{ "message": err.Error(), @@ -39,6 +37,9 @@ func CreateConnection(c *gin.Context) { return } + // store connection + conns[conn.Device.GetDeviceParams().Xaddr] = conn + c.JSON(http.StatusOK, gin.H{ "device": info, }) @@ -48,7 +49,7 @@ func GetConnections(c *gin.Context) { devices := make(map[string]interface{}) for xaddr, conn := range conns { - info, err := conn.GetDeviceInformation() + info, err := conn.GetDeviceInfo() if err != nil { c.JSON(http.StatusInternalServerError, gin.H{ "message": err.Error(), @@ -75,7 +76,7 @@ func GetConnectionByXaddr(c *gin.Context) { return } - info, err := conn.GetDeviceInformation() + info, err := conn.GetDeviceInfo() if err != nil { c.JSON(http.StatusInternalServerError, gin.H{ "message": err.Error(), diff --git a/service/onvif/connection.go b/service/onvif/connection.go index 2b18631..2f66db3 100644 --- a/service/onvif/connection.go +++ b/service/onvif/connection.go @@ -13,6 +13,7 @@ func NewConnection(xaddr string, username string, password string) (*Connection, Xaddr: xaddr, Username: username, Password: password, + AuthMode: onvif.DigestAuth, }) if err != nil { return nil, err diff --git a/service/onvif/device.go b/service/onvif/device.go index b955ebd..af423e9 100644 --- a/service/onvif/device.go +++ b/service/onvif/device.go @@ -2,7 +2,7 @@ package onvif import "github.com/IOTechSystems/onvif/device" -func (c *Connection) GetDeviceInformation() (*device.GetDeviceInformationResponse, error) { +func (c *Connection) GetDeviceInfo() (*device.GetDeviceInformationResponse, error) { resp, err := c.Device.CallMethod(device.GetDeviceInformation{}) if err != nil { return nil, err